Fixed bug #75169 (BCMath errors/warnings bypass error handling)#2745
Merged
php-pulls merged 1 commit intophp:masterfrom Sep 13, 2017
Merged
Fixed bug #75169 (BCMath errors/warnings bypass error handling)#2745php-pulls merged 1 commit intophp:masterfrom
php-pulls merged 1 commit intophp:masterfrom
Conversation
Instead of writing warning messages to `stderr`, we employ PHP's error handling to raise `E_WARNING` even for the single case where `bc_rt_error()` has been called, since that did not actually error out. We choose to call `php_error_docref()` directly in libbcmath, since there is no upstream, and since other PHP core functionality is already used in our bundled libbcmath. Accordingly, we remove `rt.c` so it will not be accidentally used in the future. Besides adapting a few existing tests, we add new tests so that the warnings are tested at least once. We also get rid of the Windows specific tests, since the warning behavior is now supposed to be platform-agnostic.
Member
Author
|
Apparently, this is uncontroversial, so I'm going to merge into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of writing warning messages to
stderr, we employ PHP's errorhandling to raise
E_WARNINGeven for the single case wherebc_rt_error()has been called, since that did not actually error out.We choose to call
php_error_docref()directly in libbcmath, sincethere is no upstream, and since other PHP core functionality is already
used in our bundled libbcmath. Accordingly, we remove
rt.cso it willnot be accidentally used in the future.
Besides adapting a few existing tests, we add new tests so that the
warnings are tested at least once. We also get rid of the Windows
specific tests, since the warning behavior is now supposed to be
platform-agnostic.