Fix LDAP path lookup on 64-bit distros#2754
Closed
dzuelke wants to merge 1 commit intophp:PHP-7.1from
Closed
Conversation
dzuelke
force-pushed
the
ldap-x64-paths
branch
from
b9f86f4 to
86fce27
Compare
Contributor
Author
|
Commit amended with a few corrections. Good to go for merge now, @krakjoe (fix applies to 7.0 and 7.2 as well). |
Contributor
Author
|
@krakjoe Y U NO MERGE? ;) |
ldap.h is in /usr/include on e.g. Ubuntu, but libldap.so and friends are in /usr/lib/x86_64-linux-gnu Fixes https://bugs.php.net/bug.php?id=49876
dzuelke
force-pushed
the
ldap-x64-paths
branch
from
86fce27 to
3255c05
Compare
Contributor
Author
|
Freshly rebased and all tests green. @krakjoe ? :) |
Member
|
Merged 8000334 Thanks (sorry about the delay) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldap.his in/usr/includeon e.g. Ubuntu, butlibldap.soand friends are in/usr/lib/x86_64-linux-gnu.Not sure if it makes sense to do it for all
ifbranches. Definitely not forlibldap.3.dylibas that's macOS.Inspired by 60aff0b (although there it's for the include dir and not the lib dir).
Fixes https://bugs.php.net/bug.php?id=49876