Fixed Bug #75212 php_value acts like php_admin_value#2756
Closed
remicollet wants to merge 2 commits intophp:PHP-7.0from
Closed
Fixed Bug #75212 php_value acts like php_admin_value#2756remicollet wants to merge 2 commits intophp:PHP-7.0from
remicollet wants to merge 2 commits intophp:PHP-7.0from
Conversation
|
The current behavior is definitely a bug in FPM. IMHO it should be safe for 7.2. For 7.0, if users occasionally have .user.ini files laying around, those suddenly start to take effect. Thanks. |
Member
|
It would be nice to add a test for that |
Member
Author
Doesn't seems easy with current FPM test framework... |
Member
|
I agree that this should be fine for 7.2 but it's not probably worth a potential break in 7.1 and 7.0. |
Member
|
@remicollet I think it should be possible if |
Member
Author
|
Test added (@bukka and indeed I forgot to set DOCUMENT_ROOT when I create the include.inc...) |
Member
|
LGTM |
Member
Author
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=75212
Open for discussion
I think that not being able to use .user.ini when a default value (php_value) is defined in the pool configuration is a bug.
But some may consider this as a breaking change (so perhaps only to be fixed in 7.2 only)