Fix bug #75301: Use dynamic revision version for exif#2799
Fix bug #75301: Use dynamic revision version for exif#2799php-pulls merged 1 commit intophp:PHP-7.0from
Conversation
|
Quite strange, since 7.1, nealy all extensions should have switched to PHP_VERSION... 1.4 doesn't make sense. (with some exceptions like oci8 or zip) |
|
Thanks @remicollet for this info. Yes, particular version besides the PHP_VERSION for extensions in the core might be confusing unless they are developed separately using PECL or something. I'll go through the extensions and fix those versions for the PHP-7.1 and up. Makes more sense now with knowing this... Would it be better to leave this PR as it is or to start with PHP_VERSION and change the target branch to PHP-7.1? |
|
In my opinion, it would be best to set the version to PHP_VERSION and to target PHP-7.0 – after all, it is a bug(fix). Cf. c3b9103. |
|
Hi As the exif extension maintainer, I would prefer that we either go with PHP's current version or simply "NO_VERSION_YET" in the module struct. It will be some time before I can do this myself so I'm open for changing this. -K |
22d3b7c to
74124de
Compare
|
In above commit the |
|
Thanks @petk, LGTM |
This patch fixes bug #75301.