Fixed bug #70469 SoapClient's fatal error in error_get_last()#2899
Fixed bug #70469 SoapClient's fatal error in error_get_last()#2899artmnv wants to merge 1 commit intophp:PHP-7.0from artmnv:bug70469_soapclient_fatal
Conversation
…ven if SoapClient is in exception mode
|
Travis failed in the same tests as PHP-7.0 branch. I'll wait for PHP-7.0 to come green. |
|
I've merged this patch into master as 1dfcd1a. I'm not applying this to any release branches, as this may have BC impact -- after all there was explicit code to throw this error, so I'm apprehensive about simply dropping it. Maybe people were using this to automatically log errors ... or something? I can be convinced to land this in 7.1+ though, if someone has more background about why the code was there in the first place. |
|
I'm also wondering why the |
|
Just for the record, this got applied to 7.1.14 and 7.2.2 at a later point as well. |
3 participants
Hello! Fixed bug https://bugs.php.net/bug.php?id=70469 when you can get fatal error from error_get_last() even if SoapClient is in exception mode.
This issue first appeared in commit a830b0f . The issue was about server side error logging but patch changed client side too. I think we don't want silent errors in SoapClient in exception mode. Please correct me if I'm wrong.