Add test for bug 75577: issue where RFC3339_EXTENDED could not be used via DateTime::createFromFormat#2945
Conversation
|
@derickr this is a fix for bug https://bugs.php.net/bug.php?id=75577 |
|
This PR should be made upstream to derickr/timelib, rather than here. |
|
Also note that parse_date.c is a generated file, be sure to apply the changes to parse_date.re then re-generate the C file. |
…me::createFromFormat" This reverts commit 5a215b8.
|
@tpunt thanks Thomas. Added PR there: derickr/timelib#29 @salathe Good catch, sorry about that newbie mistake :) |
mariano
changed the title
|
Worth noting that the bug https://bugs.php.net/bug.php?id=75577 has been resolved and timelib library has the patch merged in. Should this be closed as resolved then? |
|
@petk Not quite, I think that this test just need to be merged still. |
|
There was already a test for this, but someone forgot to close the pr ... closing now, sorry about the noise @remicollet, didn't notice bad target :( |
6 participants
Actual fix in: derickr/timelib#29