Fix #75871 - If pkg-config is available use it for libxml2#3044
Fix #75871 - If pkg-config is available use it for libxml2#3044pmmaga wants to merge 1 commit intophp:PHP-7.1from
Conversation
|
[Bug report author here] I can confirm this works with both the new version without xml2-config and the previous one with it. 👍 |
|
Thanks for the PR. Perhaps it would be more correct to keep Given that's only Debian for now, and only experimental, seems the other way round, to keep Thanks. |
|
Thanks for the feedback! I've switched the precedence so xml2-config is still used when present. |
|
Reverted trailing white-space changes |
|
@pmmaga one question yet - any particular reason to target 7.1? Experimental might land or not, actually. If it went into unstable, we could put it, but otherwise master seems a good target for us. What would you say? Thanks. |
|
As it was a bug report I just followed the standard: "lowest actively supported branch that is affected". Given the way it is now implemented, nothing will change for people that have xml2-config available, so I'd say it's safe to support this from 7.1+. If anyway you'd prefer to see this only on master I also understand the reasoning, so both ways are fine for me. |
|
@weltling I think I'm happy to merge into 7.1 if the default behaviour is retained, okay ? |
|
@krakjoe ack, please do. Of course, one can see it separate from the Debian experimental. Thanks. |
|
Merged 5673c64 Thanks. |
Link for bugsnet: https://bugs.php.net/bug.php?id=75871
This removes the dependency on
xml2-configbut keeps it as a fallback in casepkg-configis not available.