Conversation
ext/calendar/calendar.c
Outdated
|
|
||
| /* for heb_number_to_chars */ | ||
| static char alef_bet[25] = "0����������������������"; | ||
| static char alef_bet[25] = "0����������������������"; |
There was a problem hiding this comment.
Is there a way to revert this?
There was a problem hiding this comment.
You can use git checkout -p HEAD~ -- ext/calendar/calendar.c and only chose that block. Then you amend the commit.
|
After a cursory check, I notice that this added some whitepsace after some urls. Please remove that, and please confirm that every link that has been changed to HTTPS actually does support HTTPS (cursory check revealed no problems). |
@krakjoe I added that because of the table format of our license header. Is there another way to do it?
Here is a table with changes (confirmed): |
I missed that ... Can you rebase this on current master please, I get merge errors ... |
| | Zend Engine | | ||
| +----------------------------------------------------------------------+ | ||
| | Copyright (c) 1998-2010 Zend Technologies Ltd. (http://www.zend.com) | | ||
| | Copyright (c) 1998-2010 Zend Technologies Ltd. (https://www.zend.com)| |
There was a problem hiding this comment.
@krakjoe Should we update these Copyrights in other PR?
|
While reviewing phpbrew/phpbrew#953, I noticed that http://museum.php.net/ is inaccessible via HTTPS. Is there a plan to fix that? |
Use https non www PHP domain Use https in git.php.net Use https in php.ini-* Use PHP domain with https Use wiki subdomain with https Use https in W3 domain Use https in gnu domain Use https in Zend
|
@morozov I've reported a bug for the https museum: https://bugs.php.net/bug.php?id=76670 |
|
@petk Good idea, gonna create them! |
4 participants
Safety in first place 🛡️