Support using acl_* functions on *BSD#3170
Closed
mgorny wants to merge 1 commit intophp:PHP-7.1from
mgorny:bsd-libacl
Closed
Support using acl_* functions on *BSD#3170mgorny wants to merge 1 commit intophp:PHP-7.1from mgorny:bsd-libacl
mgorny wants to merge 1 commit intophp:PHP-7.1from
mgorny:bsd-libacl
Conversation
The *BSD systems have ACL routines built-in in libc rather than in separate libacl. Update the configure check to detect that and enable ACL support without adding 'acl' library.
Member
|
For reference, can you open a related bug report on bugs.php.net please and link back to it here ... |
Contributor
Author
Member
|
It seems reasonable. I plan to setup FreeBSD on my old desktop sometimes soon. I will give a try and merge it then. Thanks. |
Member
|
@bukka Did you have time to test this yet? Otherwise I'd be fine with merging this as-is. |
|
Comment on behalf of bukka at php.net: Merged via 4ea7f34 |
Member
|
Unfortunately my old desktop did not work (some hardware issue) and it will take me a bit longer to set FreeBSD up so I merged it as-is. I double checked if the build is still fine with libacl on Linux at least and all good! Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The *BSD systems have ACL routines built-in in libc rather than
in separate libacl. Update the configure check to detect that and enable
ACL support without adding 'acl' library.