Closed
Conversation
Member
|
@remicollet Can you review this? |
Member
|
Looking at https://patchwork.ozlabs.org/patch/774679/ we might want to exclude uclibc and android as well. |
On systems without glibc, such as Alpine with Musl libc, the function attributes are not supported. GCC 6 doesn't properly omit some systems. This is already fixed in GCC 7 but for systems with GCC 6 and ones without glibc, this additional check fixes this bug.
Member
Author
|
Also added uclibc and android systems with similar check as GCC 7 has it: Case is that on GCC 7 it will already work ok, but for GCC 6 won't for musl based systems: So, adding android and uclibc, shouldn't cause issues in this patch. |
Member
|
Merged as 67352cb, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems such as Alpine, Musl libc doesn't provide function attributes. Compiler (GCC) provides them, but the runtime afterwards doesn't. This additional check fixes bug #76392.