Fixed bug #62596 add getallheaders in FPM#3363
Conversation
…unction in FPM add sapi_add_request_header in public API (was add_request_header) fix arginfo for fastcgi_finish_request fucntion
remicollet
force-pushed
the
issue-getallheaders
branch
from
a652572 to
d201b34
Compare
remicollet
changed the title
|
Yessss ! Thank you, finally this gets fixed 👍 |
|
@remicollet 7.3.0alpha3 has been tagged and built; I'd rather not go through the process again, unless absolutely necessary. |
@cmb69, I mean: I really like to see this in 7.3 "IN" beta1 (so applied in master "before" ...) ;) |
|
@remicollet Ah, I see. Then just make sure that the PR will be merged before 2018-07-17. :) |
|
@remicollet I won't have much time to test it in the next few weeks but the test seems to pass and code looks good too so feel free to merge it to master now. Definitely good for the next alpha IMO! |
|
Sorry I mean for the beta1 ofc :) |
|
Merged |
|
Added a small follow up in #3373 |
|
Should we update manual http://php.net/manual/en/function.getallheaders.php move getallheaders from apache to network |
|
Any Chance this will get fixed for PHP 7, 7.1 and 7.2? |
Cf. <php/php-src#3363>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
Cf. <php/php-src#3363>. git-svn-id: http://svn.php.net/repository/phpdoc/en@345968 c90b9560-bf6c-de11-be94-00142212c4b1
Cf. <php/php-src#3363>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
Cf. <php/php-src#3363>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
6 participants
At leaset tracked as bug 62596