Fix #76712: Assignment of empty string creates extraneous text node#3431
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Closed
Fix #76712: Assignment of empty string creates extraneous text node#3431cmb69 wants to merge 1 commit intophp:PHP-7.3from
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Conversation
We work around this peculiarity of libxml by using xmlNodeSetContent(), which does not exhibit this behavior. This also saves us from manually calculating the string length.
Member
Author
|
See https://bugs.php.net/76712 for further info. |
Member
Author
|
If there are no objections, I'll apply this patch on the weekend. |
|
Comment on behalf of cmb at php.net: Applied via 692e5d5. |
Contributor
|
Looks like this tests is failing on GCOV for some reason :( |
Member
Author
|
Thanks! Might be due to the libxml2 version? We should keep an eye on this. |
Contributor
|
@cmb69 Dunno. Maybe adding the output of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We work around this peculiarity of libxml by using xmlNodeSetContent(),
which does not exhibit this behavior. This also saves us from manually
calculating the string length.