Fixed #76754: parent private constant in extends class memory leak by twose · Pull Request #3447 · php/php-src

twose · 2018-08-16T19:54:20Z

memory leak here, the size of the sub class's constants table should be added by the parent constants table size without private constants.

<?php
 class FOO
{
    private const FOO = 'BAR';
}
 class BAR extends FOO { }

twose · 2018-08-17T09:07:32Z

@laruence
I notice you have fixed it in bugs.php.net.
if check the correct constants table size is better? or you can close this pr.

laruence · 2018-08-27T05:51:02Z

Hmm, sorry, didn't notice this PR before, anyway, I think the committed way is better, since similar memory also could leak in extension classes

Fixed #76754: parent private constant in extends class memory leak

90cfbe5

twose changed the title ~~Private const extends~~ Fixed #76754: parent private constant in extends class memory leak Aug 16, 2018

twose force-pushed the private_const_extends branch from 66e9f70 to bd8a640 Compare August 17, 2018 01:52

Add Bug #76754 test script.

7d59c37

twose force-pushed the private_const_extends branch from bd8a640 to 7d59c37 Compare August 17, 2018 09:03

smalyshev added the Bug label Aug 26, 2018

smalyshev requested a review from laruence August 26, 2018 23:53

laruence closed this Aug 27, 2018

twose deleted the private_const_extends branch August 27, 2018 06:05

Provide feedback