Fix #75696: posix_getgrnam fails to print details of group#3464
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.1from
Closed
Fix #75696: posix_getgrnam fails to print details of group#3464cmb69 wants to merge 1 commit intophp:PHP-7.1from
cmb69 wants to merge 1 commit intophp:PHP-7.1from
Conversation
According to the POSIX specification of `getgrnam_r()` the result of `sysconf(_SC_GETGR_R_SIZE_MAX)` is an initial value suggested for the size of the buffer, and `ERANGE` signals that insufficient storage was supplied. So if we get `ERANGE`, we try again with a buffer twice as big, and so on, instead of failing.
Member
Author
|
Unless there'll be objections, I'm going to merge this on the next weekend. |
|
Comment on behalf of cmb at php.net: Applied via 2677d43. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the POSIX specification of
getgrnam_r()the result ofsysconf(_SC_GETGR_R_SIZE_MAX)is an initial value suggested for thesize of the buffer, and
ERANGEsignals that insufficient storage wassupplied. So if we get
ERANGE, we try again with a buffer twice asbig, and so on, instead of failing.