SOAP: Stop overwriting the node name when creating XML nodes from zvals#3584
SOAP: Stop overwriting the node name when creating XML nodes from zvals#3584camporter wants to merge 1 commit intophp:PHP-7.1from
Conversation
…ls to fix bug 50675.
camporter
changed the title
| return 0; | ||
| } | ||
| xmlNodeSetName(node, node_ptr->name); | ||
| xmlSetNs(node, node_ptr->ns); |
There was a problem hiding this comment.
If the name is no longer set, should the NS set also be dropped?
There was a problem hiding this comment.
@nikic I believe this is probably also problematic, but I will need a test case before being comfortable with removing it.
There was a problem hiding this comment.
I tried to come up with a case where there'd be different namespaces, but had trouble. Comparing test runs with and without the namespace copied didn't make a difference.
|
Comment on behalf of petk at php.net: Labelling |
|
Merged as db47e35 into 7.2+. I've included the removal of the namespace setting as well. Even if the namespace cannot actually differ, I don't think it makes sense to copy the namespace if we're no longer copying the name. I'm not applying this to 7.1 as this seems like a fairly risky change to make immediately before end of active support. |
3 participants
Fixes bug #50675.