Validate length on socket_write#3629
Closed
thiagooak wants to merge 1 commit intophp:PHP-7.1from
thiagooak:bug67619
Closed
Validate length on socket_write#3629thiagooak wants to merge 1 commit intophp:PHP-7.1from thiagooak:bug67619
thiagooak wants to merge 1 commit intophp:PHP-7.1from
thiagooak:bug67619
Conversation
cmb69
reviewed
Oct 21, 2018
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks. This looks good to me, but I'm not sure which branch to target.
KalleZ
reviewed
Oct 21, 2018
KalleZ
reviewed
Oct 21, 2018
Contributor
Author
|
@cmb69 what's a good way to figure out which branch to target? |
Member
Bugfixes should usually target PHP-7.1. The respective ticket mentions missing checks in |
Contributor
Author
|
Member
|
Thanks! LGTM. @sgolemon Okay to merge into PHP-7.1? |
Member
|
Merged ec2e7a2 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=67619