Fix #77079 odbc_fetch_object has incorrect type signature#3645
Fix #77079 odbc_fetch_object has incorrect type signature#3645ylixir wants to merge 1 commit intophp:masterfrom ylixir:bug-77079
Conversation
carusogabriel
left a comment
carusogabriel
left a comment
There was a problem hiding this comment.
The documentation for this function already uses the resource type, go it should be ready to go.
|
Looks ok then. This one goes to PHP-7.1+ then? |
If there are indeed static analyzers which use the protos, as the OP claims, this should be treated as bugfix and applied to PHP-7.1+ accordingly. |
|
Applied via 8775bea Thank you. |
|
This I think has already been closed, but for posterity, here is a screenshot of the static analyzer we use finding the issue in circle-ci: |
|
Actually the bug is duplicated in psalm and phan, and the direct cause of this problem is in its repository. |
|
Thanks @sj-i for sending fixes also there. Yes, this makes sense. |
5 participants
Bug #77079