Not sure why "pull bot" closed the MR , reopened it here
#3771

Bugs in php-pulls helper bot? Interesting...

You likely pushed master to this PR, so it effectively ended up as a no-op PR that is considered "merged".

@nikic should I always create a branch ? And not use the matser ?

@amaabdou yes. Sending pull request from the master branch is never good actually. Also because you'll have issues updating your master branch on your repository when the php master branch gets updated. For example, current master branch in php-src is already the PHP-8 branch in development actually.

A good practice:

git clone [email protected]:your-username/php-src
cd php-src
git checkout -b patch-1
git add .
git commit -m "Describe changes"
git push origin patch-1

A good practice is to also set the upstream remote in case the upstream master branch updates. This way your master branch will track remote upstream master branch of the root repository.

git checkout master
git remote add upstream git://github.com/php/php-src
git config branch.master.remote upstream
git pull --rebase

For another example, to send a pull request against the PHP upstream PHP-7.2 branch:

cd php-src
git checkout -b bug-patch upstream/PHP-7.2
git add .
git commit -m "Describe changes"
git push origin bug-patch

and open pull request to target the PHP-7.2 branch in php-src.

Thanks @petk for the advices, with all the mess I did to my repo I see what you mean clearly
But cool, Ive learned for my next PR :)