Hi,

Not sure what went wrong with the other PR anyway.

The path and path_len should be declared at the top of the block else I think the PR looks good

@KalleZ Moved hopefully to the right place :)

Thanks @amaabdou, lets see what the CI runs reports

I tried to check AppVeyor output but could not understand if my changes is related to
"Build execution time has reached the maximum allowed time for your plan (60 minutes)."
is this related to my changes ?

@amaabdou, actually as long as Travis passes I think we should be good, I reckon I saw a comment by @nikic the other day regarding the exact same issue with the timeout of AppVeyor and that we should just ignore it if Travis passes.

Thanks @KalleZ
Is there anything else here I should do for this PR ?

Can you update target branch please.

I'm not sure which target branch should be since the bug exists in all 7.x but I assumed 7.2 is the right one and re-based against it, if not please tell me which one :)

PHP 7.1 is for security related patches so yes, PHP 7.2 is the correct one here...

Sorry for the delay, now merged as ec28d4c into 7.2+. Thanks!