Conversation
|
Please no. Let's not make changes that touch the whole codebase for such frivolous reasons. |
|
@nikic, why would this cause any issue or that the change in the Git repository matter with tons of the changes done weekly here and there in the php-src code? Worth noting, that php.net site - one of the most used links across this code still doesn't have proper redirection from http:// to https:// site. Maybe I would agree if there would be at least that done but it's not yet and it won't be done for a while. So changing http to https everywhere is only smart and more browser future prone I think. Also, if we don't change this "today", someone most likely will change one day in the following years due to entire internet going to https sooner or later... |
I think it's important to point out the reason for this: The mirror system does not support HTTPS. There is only one php.net endpoint that supports HTTPS (secure.php.net), while all mirrors are HTTP. That's the real problem that needs to be solved to improve the HTTPS situation on php.net (and as far as I know, this is not easy). Just switching things to use HTTPS URLs in the php-src repo doesn't really help with that (only exacerbates the issue, really). And I think that for a license document in particular (which is also available in the repository), making this change has zero value and just pollutes the history. |
|
Sure, no worries then. I understand, but I will refer you to this PR when this issue comes up in the future... ;) |
Hello, this patch updates the
httptohttpson all places in the code where they can be located:TODO: