Closed
Conversation
Since we're putting `ITypeLib *`s into the hash, we're getting `ITypeLib *`s back, not `ITypeLib **`s.
Member
Author
|
Since the segfault happens on module shutdown, a PHPT likely makes no sense. |
Member
|
Each test is run it's own process, I think you can test for it ... |
Member
Author
|
@krakjoe Yes, a test could be as simple as: ini_set('com.autoregister_typelib', 1);
new COM('WbemScripting.SWbemLocator');
echo 'DONE';But even without this fix, the shutdown issue would not be noticable (except when actually running a debugger), since we have no valgrind support on Windows. |
Member
|
I see ... I'll shut up ... am allergic to and bad at windows :) |
Member
Author
|
@weltling Any objections to merging this? |
Member
Author
Ah, thanks! Applied as 41bc51c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're putting
ITypeLib *s into the hash, we're gettingITypeLib *s back, notITypeLib **s.