Fix #64705 PDO driver constructor throw PDOException but not setting errorInfo#3843
Closed
ahmedsbytes wants to merge 5 commits intophp:PHP-7.3from
Closed
Fix #64705 PDO driver constructor throw PDOException but not setting errorInfo#3843ahmedsbytes wants to merge 5 commits intophp:PHP-7.3from
ahmedsbytes wants to merge 5 commits intophp:PHP-7.3from
Conversation
ahmedsbytes
changed the title
…struct() fails Pdo drivers constructors are throwing PdoException wtihout setting errorInfo, so creating new reusable function that throw exceptions for pdo and will set the errorInfo also, and using this function with pdo_mysql,pdo_sqlite,pdo_pgsql. Author: Ahmed Abdou <[email protected]>
ahmedsbytes
force-pushed
the
patch_bug_64705
branch
from
35d1e0a to
cf1e2f1
Compare
Member
|
Exporting functions changes ABI, we can't change ABI in released branches. |
Member
|
@krakjoe Exporting new function is okay, as long as nothing existing changes. |
ammarfaizi2
approved these changes
Mar 3, 2019
Author
|
is there suggestion that can help to move this forward ? |
Contributor
|
Is there any possibility of this going in for php 8 at least? |
nikic
approved these changes
Aug 11, 2020
Member
|
Merged as 2fe2e5b. An annoying discrepancy is that these PDOExceptions contain the driver error code in ->code, while normally it contains the pdo error code :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
Pdo drivers constructors are throwing PdoException wtihout setting errorInfo,
so creating new reusable function that throw exceptions for pdo and will set the errorInfo also,
and using this function with pdo_mysql,pdo_sqlite,pdo_pgsql.