Merged
Conversation
…some specific contents
|
I can reproduce this in master, despite this patch is built upon 5.4. The fix works, tests pass on windows/linux |
|
Maybe one improvement though, at the end of the test one could list the files in the copied phar and compare to the original. I've used RecursiveIteratorIterator to do that. |
Member
There was a problem hiding this comment.
Assuming that the test passes after fixing the issue this comment is misleading ;-)
Contributor
Author
There was a problem hiding this comment.
Yes, it should pass anyway, I just copied the test directly from the bug and forgot to remove the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug #65028: Phar::buildFromDirectory creates corrupt archives for so...me specific contents.
Somewhat hackish solution - see https://bugs.php.net/bug.php?id=65028 for the description of the bug and suspected cause.