Close file handles and add files to included files after opening#3968
Closed
andrewnicols wants to merge 2 commits intophp:masterfrom
Closed
Close file handles and add files to included files after opening#3968andrewnicols wants to merge 2 commits intophp:masterfrom
andrewnicols wants to merge 2 commits intophp:masterfrom
Conversation
Fixes bug #76801
This change also adds the original file included to mimic the behaviour seen in PHP.
Member
|
See also PR #3965 which is supposed to be a fix for bug #76801, too. |
Author
|
Thanks @cmb69 , wish I'd known that earlier /o. I'll close this request. I've just tested 3965 locally and it solves all of the issues for me, and in a more forward-moving way. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug #76801
Note: This patch largely came from @cmb69 but I discovered that the inclusion of that patch prevented the list of included files from being filled so I've fixed that too.
I also discovered whilst fixing the list of included files that the behaviour of
phpdbgis different to that ofphpin that the original script being run was not included viaphpdbgbut is viaphp:Initial demonstration of files not closed
Script to demonstrate the issue of files not being closed:
Demonstration of included files being incomplete
Test script:
Expected result:
Actual result with PHP:
Actual result with PHPDBG before this patch: