ping @derickr

I can create the bug report and squash the commits. Targetting PHP7.2 that I don't know how to do it but if I do the first two things it will be easier for you to target 7.2 I believe

@derickr about what you asked here's a summary of what I've done 👍

• bug report
• squashing
• targeting PHP7.2

Excellent, I'll go and merge this now then.

All merged - thanks!

@derickr Curious as to why this did not initially start as a E_DEPRECATED notice for PHP 7.2 and 7.3, then target throwing an Exception in 7.4+

Since the DatePeriod::_construct() $recurrences argument was accepting <= 0 without a notice or exception since PHP 5.3

Seems like a rather significant change to the API for a patch release, that forces developers to change their code to produce the same results. https://3v4l.org/Zlqp0

From

function main(int $recurrences): \DatePeriod 
{
    return new \DatePeriod(
        new \DateTime('2012-07-01T00:00:00Z'),
        new \DateInterval('P7D'),
        $recurrences
    );
}

To

function main(int $recurrences): \DatePeriod 
{
    $interval = new \DateInterval('P7D');
    $start = new \DateTime('2012-07-01T00:00:00Z');
    if ($recurrences < 1) {
       $recurrences = clone $start;
       $recurrences->add($interval);
   }

   return new \DatePeriod($start, $interval, $recurrences);
}