[PDO] Disable cloning of PDO handle/connection objects to avoid segfault#4011
Closed
camporter wants to merge 3 commits intophp:PHP-7.2from
Closed
[PDO] Disable cloning of PDO handle/connection objects to avoid segfault#4011camporter wants to merge 3 commits intophp:PHP-7.2from
camporter wants to merge 3 commits intophp:PHP-7.2from
Conversation
Member
|
The test can be much simpler: What we are testing is that clone will fail, we're not testing for a fault here because we know it cannot happen if we prohibit clone: Just do |
Contributor
Author
|
👍 I'd originally added the additional querying because I wanted to tell if there happened to be other drivers that did not segfault after cloning before this change. Went ahead and removed the querying now. |
Member
|
Merged as 9ec1525 Thanks. |
Member
|
Followed up with a2b8a62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix for bug 77849. However, there may be connections that can clone without issue, in which case a clone handle would be needed and would need to be done selectively.