Request #72189 Add missing CURL_VERSION_* constants#4085
Closed
phansys wants to merge 1 commit intophp:PHP-7.2from
Closed
Request #72189 Add missing CURL_VERSION_* constants#4085phansys wants to merge 1 commit intophp:PHP-7.2from
CURL_VERSION_* constants#4085phansys wants to merge 1 commit intophp:PHP-7.2from
Conversation
phansys
force-pushed
the
issue_72189
branch
2 times, most recently
from
e8c8850 to
d911234
Compare
carusogabriel
changed the title
CURL_VERSION_* constantsCURL_VERSION_* constants
nikic
reviewed
Apr 29, 2019
Member
|
So, apparently those constants were already added in PHP 7.3 together with lots of other CURLOPT etc flags. Given that we made the choice not to land them on 7.2 at the time, I don't think it makes sense to backport them now. If there's any CURL_VERSION_* constants still missing on 7.3, we should add them there, of course. |
Member
|
For reference, this is what was added in 7.3: https://github.com/php/php-src/blob/PHP-7.3/UPGRADING#L560 |
Contributor
Author
|
AFAIK, there are no missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: