Fix bug #78192 PDO SQLite reset columns on schema changed#4313
Closed
vincent4vx wants to merge 1 commit intophp:PHP-7.2from
Closed
Fix bug #78192 PDO SQLite reset columns on schema changed#4313vincent4vx wants to merge 1 commit intophp:PHP-7.2from
vincent4vx wants to merge 1 commit intophp:PHP-7.2from
Conversation
…has changed Reset stmt->columns when column count changed on new execution of prepared statement
cmb69
approved these changes
Jun 28, 2019
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Note: If a column name change, but without count change, the columns descriptions is not reloaded.
I think we should adress this as well (as of SQLite 3.25.0 RENAME COLUMN is supported), but this may affect ext/sqlite3, too, and since there appears to occur no segfault (only out-dated column names), this PR is good to be merged.
Member
|
Applied as 05c00a8. Also filed https://bugs.php.net/78227 regarding |
php-pulls
pushed a commit
that referenced
this pull request
Dec 8, 2020
This has been fixed for PDO SQlite by GH-4313, however the same issue also applied to PDO MySQL. Move the column count setting function into the main PDO layer (and export it) and then use it in both PDO SQLite and PDO MySQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset stmt->columns when column count changed on new execution of prepared statement.
Since PHP 7.2, sqlite3_prepare_v2 is used, which recompile statement on schema changed (and not raise schema changed exception). This behavior will change the result set columns, which can cause a segmentation fault when column count changed.
This fix will reset the loaded columns when the count changed to ensure that there were reloaded.
New columns are now returned on fetch.
Note: If a column name change, but without count change, the columns descriptions is not reloaded.