Propagate errors from stream write operations#4433
Closed
nikic wants to merge 4 commits intophp:PHP-7.4from
Closed
Propagate errors from stream write operations#4433nikic wants to merge 4 commits intophp:PHP-7.4from
nikic wants to merge 4 commits intophp:PHP-7.4from
Conversation
nikic
commented
Jul 18, 2019
6bf6984 to
ab6ff04
Compare
Fixes bug #73535 and related.
Member
Author
|
Closing this in favor of #4442. It's better to handle reads+writes together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors inside stream write operations are currently ignored and will typically result from a 0 return value from fwrite(), contrary to documentation. This can to severe bugs, including denial of service (https://bugs.php.net/bug.php?id=73535).
This PR changes the stream APIs to use a ssize_t return value, where negative returns indicate an error, similar to the
write()libc function. This is then propagated through various stream wrappers and using functions. There's probably more places that can check for errors, but this puts the basic scaffolding in place.Ideally something similar would also be done for read operations.