Set CLI exit code to 1 when invalid parameters are passed#4466
Closed
pierredup wants to merge 3 commits intophp:PHP-7.2from
Closed
Set CLI exit code to 1 when invalid parameters are passed#4466pierredup wants to merge 3 commits intophp:PHP-7.2from
pierredup wants to merge 3 commits intophp:PHP-7.2from
Conversation
Contributor
carusogabriel
left a comment
There was a problem hiding this comment.
Can we add a unit test for this one?
Author
|
@carusogabriel Done |
cmb69
reviewed
Jul 23, 2019
Member
|
Looks like some of the new tests are failing: and |
Member
|
@pierredup what is the status of this PR ? |
Author
|
@krakjoe Just trying to get the tests to pass, will have it fixed in the next couple of days |
Author
|
Fixed in #5093 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=78323
When running php with invalid option, e.g. "php --memory-limit=1G" instead "php -dmemory-limit=1G" the PHP help is displayed and return code 1 instead of 0