Fix #78349: Bundled pcre2 library missing LICENCE file#4483
Fix #78349: Bundled pcre2 library missing LICENCE file#4483petk wants to merge 2 commits intophp:PHP-7.4from
Conversation
The PCRE library is noted in short on two places: - README.REDIST.BINS - CONTRIBUTING.md so contributors know where to send patches to upstream and users are now also more familiar with its LICENSE and basic info. Other documentation related files are not included since they might get outdated soon. Links to upstream location is better way to note its usage, their authors and its license.
|
The file should be spelled LICENSE, not LICENCE. |
Yes, good one. Renamed. The pcrelib otherwise uses non-American spelling for this file - LICENCE: |
|
If PCRE uses the LICENCE spelling itself, it might be better to keep it, so this is just a file shipped without modification -- the filename reference in README.REDIST.BINS just needs to be consistent with that. |
|
Hm, yes. Very true... I don't like this actually. Adding a new file "type" in the repo is not something I want to do (yes, that pedantic :). I was also thinking about adding a README.md file in the ext/pcre then with a short info about pcrelib directory and what it is etc. But the contributing file with its directory structure is enough from my point of view. I think php-src should aim more in the direction of using the system's pcre library if that is even possible. Case is here that php-src is still not so much optimal regarding the project root and all the files that are in it. But that is a topic for some other time... If it's ok with everyone I would only update that README.REDIST.BINS with the latest pcre license content then... |
|
Applied via a8c97f0 (update in README.REDIST.BINS only). |
3 participants
Fixes https://bugs.php.net/bug.php?id=78349
The PCRE library is noted in short on two places:
so contributors know where to send patches to upstream and users are
now also more familiar with its LICENSE and basic info. Other
documentation related files are not included since they might get
outdated soon. Links to upstream location is better way to note its
usage, their authors and its license.
P.S: LICENSE file is bundled from the upstream PCRE 10.33 release