Closed
Conversation
Contributor
Author
|
Basically copy() copies the file, but filesize() displays wrong information because copy calls stat, and stat stores in cache information that gets old after copy is completed. |
Contributor
Author
|
PR updated accordingly (UT changes) |
Contributor
|
I think a better solution would be to add a flag for _php_stream_stat_path so that it would not cache the result. Caching the result only to throw it out is not the best way. |
https://bugs.php.net/bug.php?id=65701 Do not use cache for file file copy
Contributor
Author
|
PR updated as per suggestion. |
|
Comment on behalf of stas at php.net: merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=65701
Do not use cache for file file copy