Implemented FR #65917 (getallheaders() is not supported by the built-in web server)#496
Implemented FR #65917 (getallheaders() is not supported by the built-in web server)#496hikari-no-yume wants to merge 3 commits intophp:masterfrom
Conversation
|
I'm not sure it is a good idea to keep aliasing, if necessary can be implemented in user-land: if (!function_exists('apache_request_headers') and function_exists('getallheaders')) {
function apache_request_headers() { return getallheaders(); }
} |
|
@indeyets That battle has already been fought and lost. It's not just Apache which implements |
sapi/cli/php_cli_server.c
Outdated
There was a problem hiding this comment.
This should use zppn:
if (zend_parse_parameters_none() == FAILURE) {
return;
}
There was a problem hiding this comment.
Ah, right. Will fix.
…in...) - Implemented apache_request_headers() and getallheaders() alias in CLI server - Implemented apache_response_headers() in CLI server using FastCGI code
|
FastCGI should rename the function and keep consistency for function names (as discussed in internals ML) http_response_headers() for all SAPIs that support getting headers. I may add aliases for other SAPIs, so please use generic function name. |
|
I agree with @yohgaki |
|
Closed and re-opened new one from here: #528 - I'm going to try and get it into 5.5 instead, since it's not strictly a new feature. |
5 participants
Also implements apache_response_headers(). Note that apache_request_headers() is the real name of getallheaders(), the latter is an alias.
https://bugs.php.net/bug.php?id=65917