Convert string|array union parameter types#4995
Convert string|array union parameter types#4995kocsismate wants to merge 1 commit intophp:masterfrom
Conversation
0becb17 to
f2c6605
Compare
|
Windows build failure looks legit. |
f2c6605 to
3afdb6f
Compare
|
Not sure, but the Windows test failure might be because the null argument is now accepted (in line with general zpp rules), while previously the second mail call would fail at that point? It's really hard to say because https://github.com/php/php-src/blob/master/ext/pcre/tests/bug72463_2.phpt uses EXPECTREGEX and I'm not sure what the usual output is and what we get now. @cmb69 Could you take a look at what's going on here? |
|
I also suspected the |
3afdb6f to
de3d6b8
Compare
|
Well, indeed, the failing tests hadbeen caused by an unrelated bug which has been fixed in the meantime, and after the rebase everything looks good. I think this is good to be merged. Thanks. |
Convert
strtr()andmail().