Open
Conversation
Convert serialize_lock into a lock_level, so that a new context is created if lock_level == level, but the context is reused if lock_level < level. This makes serialization behavior consistent independently of whether locking is active or not: It only prevents a context reuse at a specific level.
Member
Author
|
@smalyshev If you have time, could you take a look at this change? |
Member
|
@nikic It looks like @smalyshev gave you a "thumbs up." Can you rebase and merge this? |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Member
|
This is still worth leaving open as it fixes valid issue and just need a rebase. |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert serialize_lock into a lock_level, so that a new context is
created if lock_level == level, but the context is reused if
lock_level < level. This makes serialization behavior consistent
independently of whether locking is active or not: It only prevents
a context reuse at a specific level.
This is a proper fix for https://bugs.php.net/bug.php?id=79031.