Fix #79078: Hypothetical use-after-free in curl_multi_add_handle()#5064
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Closed
Fix #79078: Hypothetical use-after-free in curl_multi_add_handle()#5064cmb69 wants to merge 1 commit intophp:PHP-7.3from
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Conversation
To avoid this, we have to verify the handlers already in `curl_multi_add_handle()`, not only in `curl_multi_exec()`.
nikic
approved these changes
Jan 8, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
This is fine, but remains fragile. Ideally we'd use FPs independent of the PHP stream here, but I'm not sure if that's possible on Windows (on Linux FP can be duplicated via fileno -> dup -> fdopen).
Member
Author
|
That should work the same on Windows (the functions should better be prefixed with an underscore there, since the POSIX function names are deprecated). But I think that's better left for master. |
Member
Author
|
Thanks! Applied as 0dda4a8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid this, we have to verify the handlers already in
curl_multi_add_handle(), not only incurl_multi_exec().