ticket-78385 an empty string in parse_url() return when question mark…#5078
Closed
fu22ybear wants to merge 3 commits intophp:masterfrom
Closed
Conversation
nikic
reviewed
Jan 11, 2020
Contributor
|
I know that this was report as a bug, but is there any change that this would break routers libraries or even frameworks? |
Member
Contributor
Author
|
I missed this test files, they have to be updated too |
Member
|
@Islam93, ah thanks! While I agree that it's more correct to report an empty |
Contributor
Author
|
@cmb69, even it will not be merged, this issue was useful for me like first try to contribute to php :) |
Member
|
If nothing else, this change should be fine to merge into |
Contributor
Author
@nikic, ok, I will update current PR |
fu22ybear
force-pushed
the
parse_url_does_not_include_query_when_question_mark_is_the_last
branch
from
52c1be5 to
90a83e2
Compare
nikic
approved these changes
Jan 13, 2020
Contributor
|
Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is the last
bug ticket 78385