Set CLI exit code to 1 when invalid parameters are passed#5093
Closed
diafour wants to merge 5 commits intophp:masterfrom
Closed
Set CLI exit code to 1 when invalid parameters are passed#5093diafour wants to merge 5 commits intophp:masterfrom
diafour wants to merge 5 commits intophp:masterfrom
Conversation
- cli, cgi and phpdbg print error to sdterr
Contributor
Author
|
This PR tries to fulfill some thoughts from this review: #4466 (review) |
nikic
reviewed
Jan 21, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
This looks good to me, I'd only like to see the new -2 value given a proper name. Like PHP_GETOPT_INVALID_ARG or so.
diafour
commented
Jan 23, 2020
nikic
approved these changes
Jan 23, 2020
Member
|
I think this should be fine for 7.3. It changes the exit code, but only in an error case, where execution of the program is aborted. As such, I don't see how this could cause a practical backwards compatibility issue. Does anyone have concerns about this? |
chamajcpradel
approved these changes
Jan 24, 2020
chamajcpradel
left a comment
chamajcpradel
left a comment
There was a problem hiding this comment.
Sirs. I will have to adjust my local scripts. LGTM.
Member
|
Merged as fd08f06 into 7.3. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This is a continuation of #4466 with some enhancements: