Fix #79146: cscript can fail to run on some systems#5101
Fix #79146: cscript can fail to run on some systems#5101clarodeus wants to merge 1 commit intophp:masterfrom
Conversation
clarodeus
force-pushed
the
cscript-fix
branch
from
e6c9a7c to
257afc5
Compare
clarodeus
changed the title
clarodeus
force-pushed
the
cscript-fix
branch
from
257afc5 to
0180c77
Compare
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Ah, good catch. Thanks! I think one further occurance has to be changed as well:
php-src/win32/build/phpize.bat
Line 3 in 5217666
clarodeus
force-pushed
the
cscript-fix
branch
from
0180c77 to
bf6fedd
Compare
Thanks for pointing that out! I've added the flag there as well. |
Seems that didn't make it in. Also, I think we should treat this as bug fix (having the .js extension associated with some other enginge is likely not uncommon), and apply the patch to PHP-7.3. |
In the buildconf and configure batch files, Windows' cscript utility was being run without the /e:jscript flag. This works on systems that have not had the default .js file association changed, but if .js has been re-associated to (say) an IDE, the batch files fail with the error message: Input Error: There is no script engine for file extension ".js".
clarodeus
force-pushed
the
cscript-fix
branch
from
bf6fedd to
f346c9e
Compare
|
It seems I did I double-checked this time, and it's definitely in the PR now. As far as targeting PHP 7.3, would you like me to do the rebase? |
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks! LGTM now.
No need to rebase, since the patch applies cleanly on PHP-7.3. I'll merge this PR ASAP.
|
Applied as 3046e35. Thanks! |
2 participants
In the buildconf and configure batch files, Windows' cscript utility was being
run without the /e:jscript flag. This works on systems that have not had the
default .js file association changed, but if .js has been re-associated to
(say) an IDE, the batch files fail with the error message:
Input Error: There is no script engine for file extension ".js".
This PR fixes the issue by inserting the neccessary flag.