Native Windows support for mysqlnd sha256 authentification#5210
Closed
cmb69 wants to merge 5 commits intophp:PHP-7.4from
Closed
Native Windows support for mysqlnd sha256 authentification#5210cmb69 wants to merge 5 commits intophp:PHP-7.4from
cmb69 wants to merge 5 commits intophp:PHP-7.4from
Conversation
We implement that on top of Cryptography API: Next Generation (CNG).
Member
Author
|
@johannes, @andreyhristov, @weltling, you may want to review. |
nikic
reviewed
Feb 26, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Nice work! Did you do some manual testing for this functionality? We don't have tests for it.
Member
Author
|
@nikic, thanks! I tested with MySQL 8.0.19 on Windows (users with caching_sha2_password and sha256_password authentication); all mysqli and pdo_mysql tests succeeded. I did not test on other systems. |
andreyhristov
suggested changes
Feb 26, 2020
Member
Author
|
Any further comments on this PR? If there are no objections, I'll merge this on Monday, so it makes it into PHP 7.4.4 (obviously, some users are eagerly waiting for this functionality). |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement that on top of Cryptography API: Next Generation (CNG).