Fix #79200: Some iconv functions cut Windows-1258#5231
Closed
cmb69 wants to merge 2 commits intophp:PHP-7.3from
Closed
Fix #79200: Some iconv functions cut Windows-1258#5231cmb69 wants to merge 2 commits intophp:PHP-7.3from
cmb69 wants to merge 2 commits intophp:PHP-7.3from
Conversation
To cater to potentially state-dependent encodings, we have to reset the conversion descriptor into its initial shift state to properly finish the conversion. Furthermore, state-dependent encodings may not show progress when comparing `in_left` before and after the conversion; we rather have to see whether `out_left` has decreased. Also we have to cater to the fact that the final potentially state resetting call does not signal failure, but we still have to break respective loops afterwards.
Member
Author
|
If there are no objections, I'll merge this in a week. |
nikic
reviewed
Mar 16, 2020
Ensure that iconv() behaves as expected.
nikic
approved these changes
Mar 16, 2020
Member
Author
|
Thanks! Applied as 32a2644. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To cater to potentially state-dependent encodings, we have to reset the
conversion descriptor into its initial shift state to properly finish
the conversion. Furthermore, state-dependent encodings may not show
progress when comparing
in_leftbefore and after the conversion; werather have to see whether
out_lefthas decreased. Also we have tocater to the fact that the final potentially state resetting call does
not signal failure, but we still have to break respective loops
afterwards.