Allow NULL as value for CURLOPT_CUSTOMREQUEST option.#531
Allow NULL as value for CURLOPT_CUSTOMREQUEST option.#531datibbaw wants to merge 1 commit intophp:masterfrom
Conversation
ext/curl/interface.c
Outdated
There was a problem hiding this comment.
what happened to indentation here?
There was a problem hiding this comment.
Yikes. Indentation fail.
There was a problem hiding this comment.
Die Zustellung an folgende Empfänger oder Gruppen verzögert sich:
[email protected]:[email protected]
Betreff: Re: [php-src] Allow NULL as value for CURLOPT_CUSTOMREQUEST option. (#531)
Diese Nachricht wurde noch nicht zugestellt. Es wird weiterhin versucht, die Nachricht zuzustellen.
Der Server wird noch 2 Tage, 22 Stunden und 52 Minuten versuchen, die Nachricht zuzustellen. Sie erhalten eine Benachrichtigung, falls die Nachricht bis dahin nicht übermittelt werden konnte.
|
@smalyshev I've made the change to |
Added test case. Refactored the code to isolate the string handling. Fixed return values to use SUCCESS and FAILURE. Removed unused error variable. Indentation fix. Removed the ugly goto.
|
Comment on behalf of datibbaw at php.net: Merged into 5.5, 5.6 and master. |
4 participants
This fixes bug 66109 and addresses this so question.
It allows for a NULL value to be passed for CURLOPT_CUSTOMREQUEST, so that the internal behaviour can be reset.
The following string options are nullable as well:
And for 7.33 onwards, these may be added as well: