Fix #69264: __debugInfo() ignored while extending SPL classes#5342
Closed
cmb69 wants to merge 7 commits intophp:PHP-7.4from
Closed
Fix #69264: __debugInfo() ignored while extending SPL classes#5342cmb69 wants to merge 7 commits intophp:PHP-7.4from
cmb69 wants to merge 7 commits intophp:PHP-7.4from
Conversation
We actually implement `::__debugInfo()` and drop the `get_debug_info()` handlers of all relevant SPL classes. This is cleaner and gives more flexibility regarding overriding the functionality in descendant classes.
Member
|
Where does the difference come from? |
Member
Author
The The current PR may also be incomplete or partially wrong. PS: it was the latter. |
nikic
reviewed
Apr 3, 2020
nikic
reviewed
Apr 3, 2020
nikic
reviewed
Apr 4, 2020
nikic
reviewed
Apr 4, 2020
nikic
reviewed
Apr 4, 2020
Member
|
nikic
approved these changes
Apr 6, 2020
Member
nikic
left a comment
There was a problem hiding this comment.
Don't forget to update stubs when merging :)
Member
Author
|
Thanks! Applied as 22a077b (and merged up, ugh). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We actually implement
::__debugInfo()and drop theget_debug_info()handlers of all relevant SPL classes. This is cleaner and gives more
flexibility regarding overriding the functionality in descendant
classes.
This is an alternative solution to PR #5333. I'm afraid this can't be merged into PHP-7.4 because of the BC break (see failing tests).
PS: actually there is no real BC break.