Change parameter default to always available value#5365
Closed
cmb69 wants to merge 1 commit intophp:masterfrom
Closed
Change parameter default to always available value#5365cmb69 wants to merge 1 commit intophp:masterfrom
cmb69 wants to merge 1 commit intophp:masterfrom
Conversation
`SIGTERM` is only defined in ext/pcntl, and as such never available on Windows. Moving the constant to ext/standard does not make much sense, because that parameter is actually unused on Windows. Therefore, we use the magic number `15` instead, what is also done in the PHP manual.
nikic
approved these changes
Apr 9, 2020
Member
Author
|
Thanks! Applied as 62e8dcb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGTERMis only defined in ext/pcntl, and as such never available onWindows. Moving the constant to ext/standard does not make much sense,
because that parameter is actually unused on Windows. Therefore, we
use the magic number
15instead, what is also done in the PHP manual.