[#79521] Check __set_state structure#5462
Closed
carusogabriel wants to merge 1 commit intophp:masterfrom
carusogabriel:php8/set_state-static
Closed
[#79521] Check __set_state structure#5462carusogabriel wants to merge 1 commit intophp:masterfrom carusogabriel:php8/set_state-static
__set_state structure#5462carusogabriel wants to merge 1 commit intophp:masterfrom
carusogabriel:php8/set_state-static
Conversation
carusogabriel
changed the title
__set_state modifiers__set_state structure
carusogabriel
changed the title
__set_state structure__set_state structure
derickr
reviewed
Apr 26, 2020
Member
|
Hm, I'm wondering if we should be checking max arg number on magic methods, e.g. there's https://bugs.php.net/bug.php?id=46225. Maybe it makes sense to rewrite magic method validation in terms of validation against dummy signatures, which will then follow exact PHP signature validation semantics. |
Contributor
Author
|
@nikic Thanks for sharing that feature request, indeed is something that we could change. I'll remove the check related to arguments and I'll come up with something regarding the dummy signatures validation |
nikic
reviewed
Apr 27, 2020
nikic
approved these changes
Apr 27, 2020
Fix Bug #79521.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #4177. This fixes two problems:
static: doesn't work on PHP 8 as per 6c73b50: https://3v4l.org/KCmJS/rfc#git-php-masterpublic:__set_state's functionality doesn't work: https://3v4l.org/l4sS9Similar to #5441.