Fix #79596: MySQL FLOAT truncates to int some locales#5574
Closed
cmb69 wants to merge 2 commits intophp:PHP-7.3from
Closed
Fix #79596: MySQL FLOAT truncates to int some locales#5574cmb69 wants to merge 2 commits intophp:PHP-7.3from
cmb69 wants to merge 2 commits intophp:PHP-7.3from
Conversation
We must not do locale aware float to string conversion here; instead we using our `snprintf()` implementation with the `F` specifier.
nikic
approved these changes
May 14, 2020
Member
Author
|
Thanks! Applied as d1cd489. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must not do locale aware float to string conversion here; instead
we using our
snprintf()implementation with theFspecifier.