dns_check_record() always return true on Alpinelinux #78008#5854
Closed
andypost wants to merge 1 commit intophp:masterfrom
Closed
dns_check_record() always return true on Alpinelinux #78008#5854andypost wants to merge 1 commit intophp:masterfrom
andypost wants to merge 1 commit intophp:masterfrom
Conversation
Contributor
Author
|
AppVeyor failed test is unrelated |
nikic
reviewed
Jul 14, 2020
nikic
reviewed
Jul 14, 2020
- free handle before return result - cleaned up remaining usage of MAXPACKET - update dns_get_mx() to use the same approach
nikic
approved these changes
Jul 15, 2020
Contributor
|
Hi o/ I've recently filed this bug report that is related to this PR. TL;DR is getmxrr seems to be still failing on our alpine based 7.4.9 pipelines. Notes from the quick discussion about this: |
Contributor
Author
|
@ekinhbayar Confirm that, when domain is wrong it still returns TRUE |
Contributor
Author
|
that's because dns reports success but empty check is wrong |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://bugs.php.net/bug.php?id=78008