Fix #70574 - Move message catalog to proper locale directory#5940
Fix #70574 - Move message catalog to proper locale directory#5940realFlowControl wants to merge 1 commit intophp:PHP-7.3from
Conversation
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Looks like these tests now fail in CI:
Gettext basic test with en_US locale that should be on nearly every system [ext/gettext/tests/gettext_basic-enus.phpt]
Test if bindtextdomain() returns string id if no directory path is set(if directory path is 'null') [ext/gettext/tests/gettext_bindtextdomain-cwd.phpt]
Test dcgettext() functionality [ext/gettext/tests/gettext_dcgettext.phpt]
Test dgettext() functionality [ext/gettext/tests/gettext_dgettext.phpt]
Test if dngettext() returns the correct translations (optionally plural). [ext/gettext/tests/gettext_dngettext-plural.phpt]
Test ngettext() functionality [ext/gettext/tests/gettext_ngettext.phpt]
|
That's interesting, locally everything was green 😉 |
realFlowControl
changed the title
realFlowControl
force-pushed
the
70574-fix-failing-gettext-tests-on-solaris
branch
from
78138e9 to
b8f7658
Compare
|
As it turns out, those six tests were actually failing also locally, I don't know what I saw there ... 😥 |
|
Converted to draft as I would like to clarify on the charset in the locale... Digging deeper I found that |
realFlowControl
force-pushed
the
70574-fix-failing-gettext-tests-on-solaris
branch
from
b8f7658 to
e42a0a3
Compare
|
Hey there 🖖 I checked how things go and found out the following. When locale is set to
Having the catalog in the Sorry for the inconvenience. Florian |
|
So the problem in the original PR was just that it used UTF8 rather than UTF-8 in the path, right? |
|
Exactly |
2 participants
Hey there 🖖
this fixes the failing tests on Solaris as stated in https://bugs.php.net/bug.php?id=70574
Kind regards
Florian