Closed
Conversation
Also it fixes test on 32-bit armv7 and x86 - Test unixtojd() function : error conditions [ext/calendar/tests/unixtojd_error1.phpt]
Member
|
Indeed, that's a bug; I just filed https://bugs.php.net/80007. Thanks for the PR! BTW, my assessment in 44c8b74 was wrong, since we're defining |
Contributor
Author
|
@cmb69 thanks a lot! |
Member
|
If this is possibly a bug in PHP, please file a bug report. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected parameter is long but used
time_tmay vary depending on arch (32 or 64 bits).Patch makes always use long (
zend_long) for function argument and cast it totime_tif neededAlso it fixes test on 32-bit armv7 and x86
Test unixtojd() function : error conditions [ext/calendar/tests/unixtojd_error1.phpt]Source of discussion https://gitlab.alpinelinux.org/alpine/aports/-/issues/11782#note_104912
Patch for PHP 8 a bit different and used in https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/9848