Fix #80061: Copying large files may have suboptimal performance#6078
Closed
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Closed
Fix #80061: Copying large files may have suboptimal performance#6078cmb69 wants to merge 3 commits intophp:PHP-7.4from
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Conversation
Instead of attempting to map large files into memory at once, we map chunks of at most `PHP_STREAM_MMAP_MAX` bytes, and repeat that until we hit the point where `php_stream_seek()` fails (see bug 54902), and copy the rest of the file by reading and writing small chunks. We also fix the mapping behavior for zero bytes on Windows, which did not error (as with `mmap()`), but would have mapped the remaining file.
cmb69
changed the title
nikic
reviewed
Sep 21, 2020
nikic
approved these changes
Sep 21, 2020
Member
Author
|
Thanks! Applied as 19c8445. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of attempting to map large files into memory at once, we map
chunks of at most
PHP_STREAM_MMAP_MAXbytes, and repeat that until wehit the point where
php_stream_seek()fails (see bug 54902), and copythe rest of the file by reading and writing small chunks.
We also fix the mapping behavior for zero bytes on Windows, which did
not error (as with
mmap()), but would have mapped the remaining file.